Join Nostr
2026-09-09 20:25:19 UTC

MoneroResearchLab on Nostr: tevador "tried to add some tests to the relative locks PRs, but got stuck on a hack ...

tevador "tried to add some tests to the relative locks PRs, but got stuck on a hack in the FCMP++ test code: https://libera.monerologs.net/no-wallet-left-behind/20260906#c705669";. rucknium asked whether relative locks interact with the old lock style being deprecated because FCMP makes locked-tx tracking harder. . rucknium asked whether relative locks interact with the old lock style being deprecated because FCMP makes locked-tx tracking harder. tevador said no: relative locks work differently and do not affect tree building. git blame on the test lines was unusable because they sit in a mega-commit; jberman later said he wrote that code and would reply in #no-wallet-left-behind.

tevador: I tried to add some tests to the relative locks PRs, but got stuck on a hack in the FCMP++ test code: https://libera.monerologs.net/no-wallet-left-behind/20260906#c705669
rucknium: IIRC, one of the reasons that the old lock style is deprecated is because FCMP makes it more complicated to keep track of the locked txs. Does relative locks have any interaction with that? (I hope not).
tevador: No, the relative locks work completely differently. They have no impact on the tree building process.
rucknium: git blame doesn't work on those lines. It's just a mega commit, it says. I was going to ask who wrote that so they could be queried.
tevador: I don't want to delay the meeting, so if someone is familiar with the test code, we can talk in #no-wallet-left-behind.
jberman: just seeing that now, will respond in a bit tevador
jberman: I wrote that
https://libera.monerologs.net/monero-research-lab/20260909#c706709
Relative locks with FCMP++:
https://github.com/monero-project/research-lab/issues/161
nevent1qqsqrrx2xrsh3j4v7l4scupa0gfusvwrvvs95p298pc9qufk30tz7es5u4l84