[ deymosh/umbra ] refactor(nip25): drop unused reaction helpers that contradicted NIP-25
extractReactionTarget took the first e/p tag where NIP-25 makes the last one the target, and isPositiveReactionContent called emoji reactions other than a heart or thumbs-up negative. Neither had a caller; counting uses engagementLinksOf and isDislikeReactionContent.
Co-Authored-By: Claude Code <noreply@anthropic.com>
https://github.com/deymosh/umbra/commit/ac6655a719dcfd9780670ca589d16604b9da2b44
nostr-summary / Nostr Summary
npub10l…sv2ux
2026-10-02 22:01:24 UTC
Author Public Key
npub10l479fv64qn03a3n0dqsryu74tyzl48xef0nc7u0z09q8tfx72ls7sv2uxPublished at
2026-10-02 22:01:24 UTCEvent JSON
{
"id": "1d554f0c461a2ef8e9d1693fcc6ce8afc4f9264754b531fffe2c5986de62f141",
"pubkey": "7febe2a59aa826f8f6337b4101939eaac82fd4e6ca5f3c7b8f13ca03ad26f2bf",
"created_at": 1790978484,
"kind": 1,
"tags": [
[
"proxy",
"https://github.com/deymosh/umbra/commit/ac6655a719dcfd9780670ca589d16604b9da2b44",
"web"
]
],
"content": "[ deymosh/umbra ] refactor(nip25): drop unused reaction helpers that contradicted NIP-25\n\nextractReactionTarget took the first e/p tag where NIP-25 makes the last one the target, and isPositiveReactionContent called emoji reactions other than a heart or thumbs-up negative. Neither had a caller; counting uses engagementLinksOf and isDislikeReactionContent.\n\nCo-Authored-By: Claude Code \u003cnoreply@anthropic.com\u003e\nhttps://github.com/deymosh/umbra/commit/ac6655a719dcfd9780670ca589d16604b9da2b44",
"sig": "e15a33aa6d62343e1404e3c772a90298c84040895403b42ab2bc9a8280a73decc8a9c6f516de1eefe9f355b4d428030b7808ea6326184b18f9e7c0e89e06c9db"
}