rich1.0Bastien TEINTURIER [ARCHIVE] (npub17f…ntr0s)https://yabu.me/npub17fjkngg0s0mfx4uhhz6n4puhflwvrhn2h5c78vdr5xda4mvqx89swntr0snjumphttps://yabu.me📅 Original date posted:2021-06-30 📝 Original message: > > - MUST NOT send `announcement_signatures` messages until `funding_locked` > has been sent and received AND the funding transaction has at least > six confirmations. > > So still compliant there? > Great, I hadn't spotted that one, so we're good on the `announcement_signatures` side. I'm wondering if `option_zeroconf` implies that we should set `min_depth = 0` in `accept_channel`, since that's the number of confirmations before we can send `funding_locked`. We need a signal that this channel uses zero-conf, and the two obvious choices are: - set `min_depth = 0` - use a `channel_type` that sets `option_zeroconf` I think the second option is better, this way we can keep a "normal" `min_depth` set and when we send `funding_locked`, we know that the channel is now perfectly safe to use (out of the zero-conf zone). Cheers, Bastien Le mer. 30 juin 2021 à 02:09, Rusty Russell <rusty at rustcorp.com.au> a écrit : > Bastien TEINTURIER <bastien at acinq.fr> writes: > > Hi Rusty, > > > > On the eclair side, we instead send `funding_locked` as soon as we > > see the funding tx in the mempool. > > > > But I think your proposal would work as well. > > This would be backward compatible, I think. Eclair would send > `funding_locked`, which is perfectly legal, but a normal peer would > still wait for confirms before also sending `funding_locked`; it's > just that option_zeroconf_channels would mean it doesn't have to > wait for that before sending HTLCs? > > > We may want to defer sending `announcement_signatures` until > > after the funding tx has been confirmed? What `min_depth` should > > we use here? Should we keep a non-zero value in `accept_channel` > > or should it be zero? > > You can't send it before you know the channel_id, so it has to be at > least 1. Spec says: > > - MUST NOT send `announcement_signatures` messages until > `funding_locked` > has been sent and received AND the funding transaction has at least > six confirmations. > > So still compliant there? > > Cheers, > Rusty. > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linuxfoundation.org/pipermail/lightning-dev/attachments/20210630/f022c575/attachment.html>